feat(news): read sentiment_score with v1 fallback#112
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Hfd5GY7STjojT7kSrZSqF
Match the fail-loud convention of every other required field in _project_entry; score=None would otherwise flow silently into the panel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Hfd5GY7STjojT7kSrZSqF
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Hfd5GY7STjojT7kSrZSqF
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer-first half of FinSearch's score-field disambiguation (
editorial_score/sentiment_score, schema v2).sentiment_score, falls back toscore(v1) — fails loud if neither, matching every other required field in_project_entry.{1, 2}; items pin stays== 1.NewsSentimentEntry.score, panel JS) unchanged — only the wire key read changes.sentiment_scoredocumented canonical + transitional note.PR-2 (after FinSearch's v2 deploy) deletes the fallback and pins
schema_version == 2.Merge gate: this must merge + deploy before the FinSearch v2 PR merges.
Suite: 973 passed, 4 skipped.
🤖 Generated with Claude Code
https://claude.ai/code/session_012Hfd5GY7STjojT7kSrZSqF